refactor(aria/combobox): make input readonly when disabled#33187
Merged
tjshiu merged 1 commit intoangular:mainfrom May 2, 2026
Merged
refactor(aria/combobox): make input readonly when disabled#33187tjshiu merged 1 commit intoangular:mainfrom
tjshiu merged 1 commit intoangular:mainfrom
Conversation
Contributor
tjshiu
commented
May 1, 2026
tjshiu
commented
- issues when we have simple-combobox and softDisabled
- need the input or textarea element to still be readable without marking it disabled since it would block the focus on it (preventing soft disabled)
tjshiu
added
target: major
ok7sai
approved these changes
May 1, 2026
|
Deployed dev-app for 6db4781 to: https://ng-dev-previews-comp--pr-angular-components-33187-dev-aaaa5eus.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
adolgachev
approved these changes
May 2, 2026
Contributor
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.